linux-kernel - Re: [PATCH V3 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CADnq5_MTgMtHM87YQJcZLcENevcHOuQihoTz-xRetypJ6BQSXQ@mail.gmail.com>
Date:   Wed, 19 Apr 2023 09:49:08 -0400
From:   Alex Deucher <alexdeucher@...il.com>
To:     Christian König <christian.koenig@....com>
Cc:     hackyzh002 <hackyzh002@...il.com>, alexander.deucher@....com,
        Xinhui.Pan@....com, linux-kernel@...r.kernel.org,
        amd-gfx@...ts.freedesktop.org, linaro-mm-sig@...ts.linaro.org,
        dri-devel@...ts.freedesktop.org, sumit.semwal@...aro.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH V3 1/2] drm/radeon: Fix integer overflow in radeon_cs_parser_init

Applied.  Thanks!

Alex

On Wed, Apr 19, 2023 at 8:24 AM Christian König
<christian.koenig@....com> wrote:
>
> Am 19.04.23 um 14:20 schrieb hackyzh002:
> > The type of size is unsigned, if size is 0x40000000, there will be an
> > integer overflow, size will be zero after size *= sizeof(uint32_t),
> > will cause uninitialized memory to be referenced later
> >
> > Signed-off-by: hackyzh002 <hackyzh002@...il.com>
>
> Reviewed-by: Christian König <christian.koenig@....com> for the series.
>
> > ---
> >   drivers/gpu/drm/radeon/radeon_cs.c | 3 ++-
> >   1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/radeon/radeon_cs.c b/drivers/gpu/drm/radeon/radeon_cs.c
> > index 46a27ebf4..a6700d727 100644
> > --- a/drivers/gpu/drm/radeon/radeon_cs.c
> > +++ b/drivers/gpu/drm/radeon/radeon_cs.c
> > @@ -270,7 +270,8 @@ int radeon_cs_parser_init(struct radeon_cs_parser *p, void *data)
> >   {
> >       struct drm_radeon_cs *cs = data;
> >       uint64_t *chunk_array_ptr;
> > -     unsigned size, i;
> > +     u64 size;
> > +     unsigned i;
> >       u32 ring = RADEON_CS_RING_GFX;
> >       s32 priority = 0;
> >
>