linux-kernel - Re: [PATCH 09/21] riscv: dma-mapping: skip invalidation before bidirectional DMA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <mhng-7529cf5a-4397-456f-b610-faa619d4faca@palmer-ri-x1c9>
Date:   Wed, 19 Apr 2023 07:22:51 -0700 (PDT)
From:   Palmer Dabbelt <palmer@...belt.com>
To:     arnd@...nel.org
CC:     linux-kernel@...r.kernel.org, Arnd Bergmann <arnd@...db.de>,
        vgupta@...nel.org, linux@...linux.org.uk,
        neil.armstrong@...aro.org, linus.walleij@...aro.org,
        Catalin Marinas <catalin.marinas@....com>,
        Will Deacon <will@...nel.org>, guoren@...nel.org,
        bcain@...cinc.com, geert@...ux-m68k.org, monstr@...str.eu,
        tsbogend@...ha.franken.de, dinguyen@...nel.org, shorne@...il.com,
        deller@....de, mpe@...erman.id.au, christophe.leroy@...roup.eu,
        Paul Walmsley <paul.walmsley@...ive.com>, dalias@...c.org,
        glaubitz@...sik.fu-berlin.de, davem@...emloft.net,
        jcmvbkbc@...il.com, Christoph Hellwig <hch@....de>,
        robin.murphy@....com, prabhakar.mahadev-lad.rj@...renesas.com,
        Conor Dooley <conor.dooley@...rochip.com>,
        linux-snps-arc@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org, linux-oxnas@...ups.io,
        linux-csky@...r.kernel.org, linux-hexagon@...r.kernel.org,
        linux-m68k@...ts.linux-m68k.org, linux-mips@...r.kernel.org,
        linux-openrisc@...r.kernel.org, linux-parisc@...r.kernel.org,
        linuxppc-dev@...ts.ozlabs.org, linux-riscv@...ts.infradead.org,
        linux-sh@...r.kernel.org, sparclinux@...r.kernel.org,
        linux-xtensa@...ux-xtensa.org
Subject:     Re: [PATCH 09/21] riscv: dma-mapping: skip invalidation before bidirectional DMA

On Mon, 27 Mar 2023 05:13:05 PDT (-0700), arnd@...nel.org wrote:
> From: Arnd Bergmann <arnd@...db.de>
>
> For a DMA_BIDIRECTIONAL transfer, the caches have to be cleaned
> first to let the device see data written by the CPU, and invalidated
> after the transfer to let the CPU see data written by the device.
>
> riscv also invalidates the caches before the transfer, which does
> not appear to serve any purpose.
>
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  arch/riscv/mm/dma-noncoherent.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/riscv/mm/dma-noncoherent.c b/arch/riscv/mm/dma-noncoherent.c
> index 640f4c496d26..69c80b2155a1 100644
> --- a/arch/riscv/mm/dma-noncoherent.c
> +++ b/arch/riscv/mm/dma-noncoherent.c
> @@ -25,7 +25,7 @@ void arch_sync_dma_for_device(phys_addr_t paddr, size_t size,
>  		ALT_CMO_OP(clean, vaddr, size, riscv_cbom_block_size);
>  		break;
>  	case DMA_BIDIRECTIONAL:
> -		ALT_CMO_OP(flush, vaddr, size, riscv_cbom_block_size);
> +		ALT_CMO_OP(clean, vaddr, size, riscv_cbom_block_size);
>  		break;
>  	default:
>  		break;

Acked-by: Palmer Dabbelt <palmer@...osinc.com>