linux-kernel - Re: [PATCH v1] libperf rc_check: Enable implicitly with sanitizers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ZEGApFbdz44z9GeX@kernel.org>
Date:   Thu, 20 Apr 2023 15:12:52 -0300
From:   Arnaldo Carvalho de Melo <acme@...nel.org>
To:     Ian Rogers <irogers@...gle.com>
Cc:     Peter Zijlstra <peterz@...radead.org>,
        Ingo Molnar <mingo@...hat.com>,
        Mark Rutland <mark.rutland@....com>,
        Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
        Jiri Olsa <jolsa@...nel.org>,
        Namhyung Kim <namhyung@...nel.org>,
        Adrian Hunter <adrian.hunter@...el.com>,
        linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] libperf rc_check: Enable implicitly with sanitizers

Em Thu, Apr 20, 2023 at 10:18:12AM -0700, Ian Rogers escreveu:
> If using leak sanitizer then implicitly enable reference count
> checking.

Thanks, applied.

- Arnaldo

 
> Signed-off-by: Ian Rogers <irogers@...gle.com>
> ---
>  tools/lib/perf/include/internal/rc_check.h | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tools/lib/perf/include/internal/rc_check.h b/tools/lib/perf/include/internal/rc_check.h
> index c0626d8beb59..d5d771ccdc7b 100644
> --- a/tools/lib/perf/include/internal/rc_check.h
> +++ b/tools/lib/perf/include/internal/rc_check.h
> @@ -5,6 +5,14 @@
>  #include <stdlib.h>
>  #include <linux/zalloc.h>
>  
> +/*
> + * Enable reference count checking implicitly with leak checking, which is
> + * integrated into address sanitizer.
> + */
> +#if defined(LEAK_SANITIZER) || defined(ADDRESS_SANITIZER)
> +#define REFCNT_CHECKING 1
> +#endif
> +
>  /*
>   * Shared reference count checking macros.
>   *
> -- 
> 2.40.0.634.g4ca3ef3211-goog
> 

-- 

- Arnaldo