linux-kernel - Re: [PATCH 1/1] hwmon: (pmbus/fsp-3y) Fix functionality bitmask in FSP-3Y YM-2151E

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1eb61572-591b-44ac-8415-7f18875202f7@roeck-us.net>
Date:   Thu, 20 Apr 2023 11:19:36 -0700
From:   Guenter Roeck <linux@...ck-us.net>
To:     Tomáš Pecka <tomas.pecka@...net.cz>
Cc:     linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org,
        Jan Kundrát <jan.kundrat@...net.cz>
Subject: Re: [PATCH 1/1] hwmon: (pmbus/fsp-3y) Fix functionality bitmask in
 FSP-3Y YM-2151E

On Thu, Apr 20, 2023 at 07:19:39PM +0200, Tomáš Pecka wrote:
> The bit flags in pmbus_driver_info functionality for YM-2151E chip were
> joined with a comma operator instead of a bitwise OR. This means that
> the last constant PMBUS_HAVE_IIN was not OR-ed with the other
> PM_BUS_HAVE_* constants for this page but it initialized the next element
> of the func array (which was not accessed from anywhere because of the
> number of pages).
> 
> However, there is no need for setting PMBUS_HAVE_IIN in the 5Vsb page
> because this command does not seem to be paged. Obviously, the device
> only has one IIN sensor, so it doesn't make sense to query it again from
> the second page.
> 
> Fixes: 1734b4135a62 ("hwmon: Add driver for fsp-3y PSUs and PDUs")
> Co-developed-by: Jan Kundrát <jan.kundrat@...net.cz>
> Signed-off-by: Jan Kundrát <jan.kundrat@...net.cz>

FWIW, adding both Co-developed-by: and Signed-off-by: tags doesn't
make sense since Signed-off-by: implies Co-developed-by:.
I'll drop the first tag.

> Signed-off-by: Tomáš Pecka <tomas.pecka@...net.cz>

Applied.

Thanks,
Guenter

> ---
>  drivers/hwmon/pmbus/fsp-3y.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/hwmon/pmbus/fsp-3y.c b/drivers/hwmon/pmbus/fsp-3y.c
> index aec294cc72d1..c7469d2cdedc 100644
> --- a/drivers/hwmon/pmbus/fsp-3y.c
> +++ b/drivers/hwmon/pmbus/fsp-3y.c
> @@ -180,7 +180,6 @@ static struct pmbus_driver_info fsp3y_info[] = {
>  			PMBUS_HAVE_FAN12,
>  		.func[YM2151_PAGE_5VSB_LOG] =
>  			PMBUS_HAVE_VOUT | PMBUS_HAVE_IOUT,
> -			PMBUS_HAVE_IIN,
>  		.read_word_data = fsp3y_read_word_data,
>  		.read_byte_data = fsp3y_read_byte_data,
>  	},