linux-kernel - Re: [PATCH RESEND] PCI: xilinx: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230420191819.GA316943@bhelgaas>
Date:   Thu, 20 Apr 2023 14:18:19 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Jean Delvare <jdelvare@...e.de>
Cc:     linux-pci@...r.kernel.org, LKML <linux-kernel@...r.kernel.org>,
        Lorenzo Pieralisi <lpieralisi@...nel.org>,
        Rob Herring <robh@...nel.org>,
        Krzysztof Wilczyński <kw@...ux.com>,
        Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH RESEND] PCI: xilinx: Drop obsolete dependency on
 COMPILE_TEST

On Fri, Apr 07, 2023 at 07:08:43PM +0200, Jean Delvare wrote:
> Since commit 0166dc11be91 ("of: make CONFIG_OF user selectable"), it
> is possible to test-build any driver which depends on OF on any
> architecture by explicitly selecting OF. Therefore depending on
> COMPILE_TEST as an alternative is no longer needed.
> 
> Signed-off-by: Jean Delvare <jdelvare@...e.de>
> Cc: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Cc: Rob Herring <robh@...nel.org>
> Cc: "Krzysztof Wilczyński" <kw@...ux.com>
> Cc: Bjorn Helgaas <bhelgaas@...gle.com>

Thanks, Jean, applied to pci/controller/kconfig for v6.4.

> ---
> Resending as the context changed so my original submission no longer
> applies cleanly.
> 
>  drivers/pci/controller/Kconfig |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> --- linux-6.0.orig/drivers/pci/controller/Kconfig
> +++ linux-6.0/drivers/pci/controller/Kconfig
> @@ -98,7 +98,7 @@ config PCI_HOST_GENERIC
>  
>  config PCIE_XILINX
>  	bool "Xilinx AXI PCIe host bridge support"
> -	depends on OF || COMPILE_TEST
> +	depends on OF
>  	depends on PCI_MSI
>  	help
>  	  Say 'Y' here if you want kernel to support the Xilinx AXI PCIe
> 
> 
> -- 
> Jean Delvare
> SUSE L3 Support