linux-kernel - Re: [PATCH 07/18] arm64: dts: qcom: msm8976: correct MMC unit address

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2023 23:41:59 +0200
From:   Marijn Suijten <marijn.suijten@...ainline.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konrad.dybcio@...aro.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        Sivaprakash Murugesan <sivaprak@...eaurora.org>,
        Todor Tomov <todor.too@...il.com>,
        "Ivan T. Ivanov" <ivan.ivanov@...aro.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Luca Weiss <luca@...tu.xyz>,
        Vladimir Lypak <vladimir.lypak@...il.com>,
        Adam Skladowski <a39.skl@...il.com>,
        AngeloGioacchino Del Regno 
        <angelogioacchino.delregno@...labora.com>,
        Robert Foss <rfoss@...nel.org>,
        Andrey Konovalov <andrey.konovalov@...aro.org>,
        Vinod Koul <vkoul@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Sai Prakash Ranjan <quic_saipraka@...cinc.com>,
        Abel Vesa <abel.vesa@...aro.org>,
        Molly Sophia <mollysophia379@...il.com>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 07/18] arm64: dts: qcom: msm8976: correct MMC unit address

On 2023-04-19 23:18:45, Krzysztof Kozlowski wrote:
> Match unit-address to reg entry to fix dtbs W=1 warnings:
> 
>   Warning (simple_bus_reg): /soc@...mc@...4000: simple-bus unit address format error, expected "7824900"
>   Warning (simple_bus_reg): /soc@...mc@...4000: simple-bus unit address format error, expected "7864900"
>   Warning (simple_bus_reg): /soc@...mc@...4000: simple-bus unit address format error, expected "7a24900"
> 
> Fixes: 0484d3ce0902 ("arm64: dts: qcom: Add DTS for MSM8976 and MSM8956 SoCs")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Looks like we used/kept the "core" rather than "hc" addresses here when
porting from downstream.

Reviewed-by: Marijn Suijten <marijn.suijten@...ainline.org>

> ---
>  arch/arm64/boot/dts/qcom/msm8976.dtsi | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> index f47fb8ea71e2..753b9a2105ed 100644
> --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi
> +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi
> @@ -822,7 +822,7 @@ spmi_bus: spmi@...f000 {
>  			#interrupt-cells = <4>;
>  		};
>  
> -		sdhc_1: mmc@...4000 {
> +		sdhc_1: mmc@...4900 {
>  			compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4";
>  			reg = <0x07824900 0x500>, <0x07824000 0x800>;
>  			reg-names = "hc", "core";
> @@ -838,7 +838,7 @@ sdhc_1: mmc@...4000 {
>  			status = "disabled";
>  		};
>  
> -		sdhc_2: mmc@...4000 {
> +		sdhc_2: mmc@...4900 {
>  			compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4";
>  			reg = <0x07864900 0x11c>, <0x07864000 0x800>;
>  			reg-names = "hc", "core";
> @@ -957,7 +957,7 @@ otg: usb@...b000 {
>  			#reset-cells = <1>;
>  		};
>  
> -		sdhc_3: mmc@...4000 {
> +		sdhc_3: mmc@...4900 {
>  			compatible = "qcom,msm8976-sdhci", "qcom,sdhci-msm-v4";
>  			reg = <0x07a24900 0x11c>, <0x07a24000 0x800>;
>  			reg-names = "hc", "core";
> -- 
> 2.34.1
>