linux-kernel - Re: [PATCH v2 2/2] PCI: vmd: Clean up one inconsistent indenting warn reported by Smatch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a134567a-afa2-e7fb-fab9-d44107614e1f@linux.intel.com>
Date:   Thu, 20 Apr 2023 16:59:31 -0700
From:   "Patel, Nirmal" <nirmal.patel@...ux.intel.com>
To:     korantwork@...il.com, dlemoal@...nel.org, helgaas@...nel.org,
        kbusch@...nel.org, jonathan.derrick@...ux.dev,
        lpieralisi@...nel.org
Cc:     linux-pci@...r.kernel.org, linux-kernel@...r.kernel.org,
        Xinghui Li <korantli@...cent.com>,
        Dan Carpenter <error27@...il.com>
Subject: Re: [PATCH v2 2/2] PCI: vmd: Clean up one inconsistent indenting warn
 reported by Smatch

On 4/20/2023 2:43 AM, korantwork@...il.com wrote:
> From: Xinghui Li <korantli@...cent.com>
>
> There is one inconsistent indenting warning:
> "drivers/pci/controller/vmd.c:1058 vmd_resume()
> warn: inconsistent indenting"
>
> Fix it by formating its indenting.
>
> Reported-by: Dan Carpenter <error27@...il.com>
> Signed-off-by: Xinghui Li <korantli@...cent.com>
> ---
>  drivers/pci/controller/vmd.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/pci/controller/vmd.c b/drivers/pci/controller/vmd.c
> index 1a36e9a52b93..1b68fa606bff 100644
> --- a/drivers/pci/controller/vmd.c
> +++ b/drivers/pci/controller/vmd.c
> @@ -1056,10 +1056,10 @@ static int vmd_resume(struct device *dev)
>  	struct vmd_dev *vmd = pci_get_drvdata(pdev);
>  	int err, i;
>  
> -       if (vmd->irq_domain)
> -               vmd_set_msi_remapping(vmd, true);
> -       else
> -               vmd_set_msi_remapping(vmd, false);
> +	if (vmd->irq_domain)
> +		vmd_set_msi_remapping(vmd, true);
> +	else
> +		vmd_set_msi_remapping(vmd, false);
>  
>  	for (i = 0; i < vmd->msix_count; i++) {
>  		err = devm_request_irq(dev, vmd->irqs[i].virq,

Reviewed-by: Nirmal Patel <nirmal.patel@...ux.intel.com>