linux-kernel - Re: [PATCH 1/2] dt-bindings: regulator: Add dt property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <9f425205-c395-648a-3f42-a776c7580a8f@9elements.com>
Date:   Thu, 20 Apr 2023 13:52:30 +0530
From:   Naresh Solanki <naresh.solanki@...ements.com>
To:     Zev Weiss <zev@...ilderbeest.net>
Cc:     Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: regulator: Add dt property

Hi Zev,

On 20-04-2023 05:31 am, Zev Weiss wrote:
> On Tue, Apr 18, 2023 at 07:50:50AM PDT, Naresh Solanki wrote:
>> Add DT property regulator-supplies.
>> This enables us to couple one or more regulator output to gether. This
>> is use in case of Single connector having 2 or more supplies.
>>
>> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
>> ---
>> .../bindings/regulator/regulator-output.yaml         | 12 +++++++++---
>> 1 file changed, 9 insertions(+), 3 deletions(-)
>>
>> diff --git 
>> a/Documentation/devicetree/bindings/regulator/regulator-output.yaml 
>> b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> index 078b37a1a71a..17f683d3c1f3 100644
>> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
>> @@ -21,13 +21,19 @@ properties:
>>   compatible:
>>     const: regulator-output
>>
>> -  vout-supply:
>> +  regulator-supplies:
>>     description:
>> -      Phandle of the regulator supplying the output.
>> +      Specifies the name of the output supply provided by the regulator.
>> +      Defaults to "vout".
>> +    default: "vout"
>> +
> 
> Was this meant to be specified as a string-array to allow providing 
> multiple names?
Yes. This is string-array.
> 
>> +patternProperties:
>> +  ".*-supply":
>> +    description:
>> +      Specified the phandle for various supplies
>>
>> required:
>>   - compatible
>> -  - vout-supply
>>
>> additionalProperties: false
>>
>>
> 
> I think it would be nice to also update the examples to show what a 
> multi-supply instance would look like.
Ack. Will do that.
> 
> A slightly more descriptive subject line would also be good -- "Add dt 
> property" is a bit vague.
Suggestion ?
How about like 'Allow multiple supplies' or 'Add support for multiple 
supplies'
> 
>> base-commit: c55470f8b0616b0adb758077dbae9b19c5aac005
>> -- 
>> 2.39.1
>>
Regards,
Naresh