linux-kernel - Re: [PATCH] hwrng: histb - Move driver to drivers/char/hw

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2023 18:19:26 +0800
From:   Herbert Xu <herbert@...dor.apana.org.au>
To:     David Yang <mmyangfl@...il.com>
Cc:     linux-crypto@...r.kernel.org, Olivia Mackall <olivia@...enic.com>,
        Weili Qian <qianweili@...wei.com>,
        Zhou Wang <wangzhou1@...ilicon.com>,
        "David S. Miller" <davem@...emloft.net>,
        Conor Dooley <conor.dooley@...rochip.com>,
        Jia Jie Ho <jiajie.ho@...rfivetech.com>,
        Florian Fainelli <f.fainelli@...il.com>,
        William Zhang <william.zhang@...adcom.com>,
        Jenny Zhang <jenny.zhang@...rfivetech.com>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] hwrng: histb - Move driver to
 drivers/char/hw_random/histb-rng.c

On Mon, Apr 10, 2023 at 05:13:54PM +0800, David Yang wrote:
>
> diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig
> index 4fdf07ae3c54..1a241f37abed 100644
> --- a/drivers/char/hw_random/Kconfig
> +++ b/drivers/char/hw_random/Kconfig
> @@ -335,6 +335,18 @@ config HW_RANDOM_HISI
>  
>  	  If unsure, say Y.
>  
> +config HW_RANDOM_HISTB
> +	tristate "Hisilicon STB Random Number Generator support"
> +	depends on ARCH_HISI || COMPILE_TEST
> +	depends on HW_RANDOM
> +	default ARCH_HISI

Please drop the dependency on HW_RANDOM.

Thanks,
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt