linux-kernel - Re: [PATCH v3 2/2] pwm: sifive: change the PWM controlled LED algorithm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230420-pension-threaten-bc9a549465ab@wendy>
Date:   Thu, 20 Apr 2023 11:28:24 +0100
From:   Conor Dooley <conor.dooley@...rochip.com>
To:     Nylon Chen <nylon.chen@...ive.com>
CC:     <aou@...s.berkeley.edu>, <conor@...nel.org>,
        <emil.renner.berthing@...onical.com>, <geert+renesas@...der.be>,
        <heiko@...ech.de>, <krzysztof.kozlowski+dt@...aro.org>,
        <palmer@...belt.com>, <paul.walmsley@...ive.com>,
        <robh+dt@...nel.org>, <thierry.reding@...il.com>,
        <u.kleine-koenig@...gutronix.de>, <devicetree@...r.kernel.org>,
        <linux-pwm@...r.kernel.org>, <linux-riscv@...ts.infradead.org>,
        <linux-kernel@...r.kernel.org>, <nylon7717@...il.com>,
        <zong.li@...ive.com>, <greentime.hu@...ive.com>,
        <vincent.chen@...ive.com>
Subject: Re: [PATCH v3 2/2] pwm: sifive: change the PWM controlled LED
 algorithm

On Thu, Apr 20, 2023 at 05:34:57PM +0800, Nylon Chen wrote:
> The `frac` variable represents the pulse inactive time, and the result of
> this algorithm is the pulse active time. Therefore, we must reverse the
> result.
> 
> The reference is SiFive FU740-C000 Manual[0]
> 
> Link: https://sifive.cdn.prismic.io/sifive/1a82e600-1f93-4f41-b2d8-86ed8b16acba_fu740-c000-manual-v1p6.pdf [0]
> 
> Acked-by: Conor Dooley <conor.dooley@...rochip.com>
> Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>

Hmm, I don't recall reviewing or acking this patch. I do recalling doing
it for 1/2 though:
https://lore.kernel.org/linux-pwm/Y9len4GinXQ101xr@spud/

Please remove these from your next submission, I don't have any knowledge
of this driver nor do I maintain it, thanks.

> Signed-off-by: Nylon Chen <nylon.chen@...ive.com>
> Signed-off-by: Vincent Chen <vincent.chen@...ive.com>

This SoB is new too AFAICT and looks a bit odd.
Should there be a Co-developed-by for Vincent?

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)