linux-kernel - Re: [PATCH] firmware:Remove unnecessary (void*) conversions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Thu, 20 Apr 2023 12:33:51 +0200
From:   Marek Behún <marek.behun@....cz>
To:     yunchuan <yunchuan@...china.com>
Cc:     kabel@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware:Remove unnecessary (void*) conversions

This makes sense, but the commit title should be
  firmware: turris-mox-rwtm: drop unnecessary (void *) conversion

On Thu, Apr 20, 2023 at 03:37:51PM +0800, yunchuan wrote:
> Pointer variables of void * type do not require type cast.
> 
> Signed-off-by: yunchuan <yunchuan@...china.com>
> ---
>  drivers/firmware/turris-mox-rwtm.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/turris-mox-rwtm.c b/drivers/firmware/turris-mox-rwtm.c
> index 6ea5789a89e2..af2fa620e6bc 100644
> --- a/drivers/firmware/turris-mox-rwtm.c
> +++ b/drivers/firmware/turris-mox-rwtm.c
> @@ -283,7 +283,7 @@ static int check_get_random_support(struct mox_rwtm *rwtm)
>  
>  static int mox_hwrng_read(struct hwrng *rng, void *data, size_t max, bool wait)
>  {
> -	struct mox_rwtm *rwtm = (struct mox_rwtm *) rng->priv;
> +	struct mox_rwtm *rwtm = rng->priv;
>  	struct armada_37xx_rwtm_tx_msg msg;
>  	int ret;
>  
> -- 
> 2.30.2
>