linux-kernel - Re: [PATCH v4 1/2] printk: Do not delay messages which aren't solicited by any console

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEFCfJLteNo91n-f@chrisdown.name>
Date:   Thu, 20 Apr 2023 14:47:40 +0100
From:   Chris Down <chris@...isdown.name>
To:     John Ogness <john.ogness@...utronix.de>
Cc:     linux-kernel@...r.kernel.org, Petr Mladek <pmladek@...e.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sergey Senozhatsky <senozhatsky@...omium.org>,
        Steven Rostedt <rostedt@...dmis.org>,
        Geert Uytterhoeven <geert@...ux-m68k.org>, kernel-team@...com
Subject: Re: [PATCH v4 1/2] printk: Do not delay messages which aren't
 solicited by any console

John Ogness writes:
>On 2023-04-20, Chris Down <chris@...isdown.name> wrote:
>> diff --git a/kernel/printk/printk.c b/kernel/printk/printk.c
>> index fd0c9f913940..06f16a5f1516 100644
>> --- a/kernel/printk/printk.c
>> +++ b/kernel/printk/printk.c
>> @@ -1289,15 +1289,13 @@ static int __init boot_delay_setup(char *str)
>>  }
>>  early_param("boot_delay", boot_delay_setup);
>>
>> -static void boot_delay_msec(int level)
>> +static void boot_delay_msec(void)
>>  {
>>  	unsigned long long k;
>>  	unsigned long timeout;
>>
>>  	if ((boot_delay == 0 || system_state >= SYSTEM_RUNNING)
>
>            ^----- you will need to remove this paren as well

That'll teach me to compile test without remembering it also needs 
CONFIG_BOOT_PRINTK_DELAY=y :-) Thanks.

>
>> -		|| suppress_message_printing(level)) {
>>  		return;
>> -	}
>
>John Ogness