linux-kernel - Re: [PATCH] scsi: advansys: disallow ISA-only build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <d018f78d-13d0-4d13-90c5-9b33bd121f51@app.fastmail.com>
Date:   Thu, 20 Apr 2023 16:25:50 +0200
From:   "Arnd Bergmann" <arnd@...db.de>
To:     "Pascal Hambourg" <pascal@...uf.fr.eu.org>,
        "Martin K. Petersen" <martin.petersen@...cle.com>
Cc:     linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org,
        "Bartlomiej Zolnierkiewicz" <bzolnier@...il.com>
Subject: Re: [PATCH] scsi: advansys: disallow ISA-only build

On Thu, Apr 20, 2023, at 14:40, Pascal Hambourg wrote:
> Hello Arnd, Peter,
>
> Arnd Bergmann wrote:
>> The ISA support for this driver was removed a while ago,
>> but the Kconfig dependencies still need an update to require
>> EISA or PCI.
>
> A month ago I posted to linux-scsi about the module failing to to init 
> if ISA support is disabled in the kernel config (copy attached), but 
> have not received any answer so far. Any thoughts ?
> Attachments:
> * [Bug report] scsi: advansys: module init fails if ISA_BUS_API is not set.eml
[https://lore.kernel.org/all/5b30b2b2-c47a-da1e-8106-025c914faebd@plouf.fr.eu.org]

Thanks for getting back to me on that. It looks like my patch
was incorrect after all, and only the ISA_DMA_API should have
been removed, as it's now impossible to build a VLB-only version
of the driver.

I think the two ways we can address this are:

- your approach c), which makes it behave the same as the aha1542.c and
  g_NCR5380.c drivers, plus a Kconfig fix to add back ISA_BUS_API
  as a possible alternative to PCI and EISA (thus fixing my patch).

- your approach d), removing VLB support for this driver. I tried to
  find other VLB drivers and the only ones I see remaining in linux-6.3
  are drivers/ata/pata_legacy and drivers/net/ethernet/amd/pcnet32.c.
  Bartlomiej Zolnierkiewicz (added to Cc) is the only one that I can
  see having actually touched VLB drivers at all in over a decade, he
  might know more.

      Arnd