linux-kernel - Re: [PATCH 2/3] drm/amd/display: dumb_abm_lcd: avoid missing-prototype warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <0ff3f8b3-dbd9-e9b5-d015-42d39f346be2@amd.com>
Date:   Thu, 20 Apr 2023 10:29:53 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Arnd Bergmann <arnd@...nel.org>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Leon Huang <Leon.Huang1@....com>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Qingqing Zhuo <qingqing.zhuo@....com>,
        Wenjing Liu <wenjing.liu@....com>,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org, Jun Lei <Jun.Lei@....com>,
        Josip Pavic <Josip.Pavic@....com>,
        Nicholas Kazlauskas <Nicholas.Kazlauskas@....com>
Subject: Re: [PATCH 2/3] drm/amd/display: dumb_abm_lcd: avoid
 missing-prototype warnings

On 4/20/23 04:47, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> The dmub_abm_set_ambient_level() function has no caller and can
> just be removed, the other ones have a declaration in the
> header file and just need to see the prototype:
> 
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:122:14: error: no previous prototype for function 'dmub_abm_get_current_backlight' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:133:14: error: no previous prototype for function 'dmub_abm_get_target_backlight' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:144:6: error: no previous prototype for function 'dmub_abm_set_level' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:163:6: error: no previous prototype for function 'dmub_abm_set_ambient_level' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:183:6: error: no previous prototype for function 'dmub_abm_init_config' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:213:6: error: no previous prototype for function 'dmub_abm_set_pause' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:231:6: error: no previous prototype for function 'dmub_abm_set_pipe' [-Werror,-Wmissing-prototypes]
> drivers/gpu/drm/amd/amdgpu/../display/dc/dce/dmub_abm_lcd.c:251:6: error: no previous prototype for function 'dmub_abm_set_backlight_level' [-Werror,-Wmissing-prototypes]
> 
> Fixes: b8fe56375f78 ("drm/amd/display: Refactor ABM feature")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>

Applied, thanks!

> ---
>   .../gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c | 22 +------------------
>   1 file changed, 1 insertion(+), 21 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c
> index e152c68edfd1..39da73eba86e 100644
> --- a/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c
> +++ b/drivers/gpu/drm/amd/display/dc/dce/dmub_abm_lcd.c
> @@ -24,6 +24,7 @@
>    */
>   
>   #include "dmub_abm.h"
> +#include "dmub_abm_lcd.h"
>   #include "dce_abm.h"
>   #include "dc.h"
>   #include "dc_dmub_srv.h"
> @@ -159,27 +160,6 @@ bool dmub_abm_set_level(struct abm *abm, uint32_t level, uint8_t panel_mask)
>   	return true;
>   }
>   
> -#ifndef TRIM_AMBIENT_GAMMA
> -void dmub_abm_set_ambient_level(struct abm *abm, unsigned int ambient_lux, uint8_t panel_mask)
> -{
> -	union dmub_rb_cmd cmd;
> -	struct dc_context *dc = abm->ctx;
> -
> -	if (ambient_lux > 0xFFFF)
> -		ambient_lux = 0xFFFF;
> -
> -	memset(&cmd, 0, sizeof(cmd));
> -	cmd.abm_set_ambient_level.header.type = DMUB_CMD__ABM;
> -	cmd.abm_set_ambient_level.header.sub_type = DMUB_CMD__ABM_SET_AMBIENT_LEVEL;
> -	cmd.abm_set_ambient_level.abm_set_ambient_level_data.ambient_lux = ambient_lux;
> -	cmd.abm_set_ambient_level.abm_set_ambient_level_data.version = DMUB_CMD_ABM_CONTROL_VERSION_1;
> -	cmd.abm_set_ambient_level.abm_set_ambient_level_data.panel_mask = panel_mask;
> -	cmd.abm_set_ambient_level.header.payload_bytes = sizeof(struct dmub_cmd_abm_set_ambient_level_data);
> -
> -	dm_execute_dmub_cmd(dc, &cmd, DM_DMUB_WAIT_TYPE_WAIT);
> -}
> -#endif
> -
>   void dmub_abm_init_config(struct abm *abm,
>   	const char *src,
>   	unsigned int bytes,
-- 
Hamza