[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <99c2ec7c-bff2-fa50-f267-d5ca383bd5ca@collabora.com>
Date: Thu, 20 Apr 2023 16:32:27 +0200
From: AngeloGioacchino Del Regno
<angelogioacchino.delregno@...labora.com>
To: Daniel Golle <daniel@...rotopia.org>, linux-pwm@...r.kernel.org,
linux-mediatek@...ts.infradead.org,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Thierry Reding <thierry.reding@...il.com>,
Uwe Kleine-König <u.kleine-koenig@...gutronix.de>,
Matthias Brugger <matthias.bgg@...il.com>,
John Crispin <john@...ozen.org>
Subject: Re: [PATCH v2 2/2] pwm: mediatek: Add support for MT7981
Il 20/04/23 14:36, Daniel Golle ha scritto:
> The PWM unit on MT7981 uses different register offsets than previous
> MediaTek PWM units. Add support for these new offsets and add support
> for PWM on MT7981 which has 3 PWM channels, one of them is typically
> used for a temperature controlled fan.
>
> Signed-off-by: Daniel Golle <daniel@...rotopia.org>
The implementation is good now; there's only one nitpick: you're reordering
the platform data entries and I agree about doing that, as they should be
alphabetically sorted, but you didn't mention that in the commit message.
Please send a v3 that mentions that you're also reordering.
"...while at it, also reorder..."
After which:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>
Powered by blists - more mailing lists