linux-kernel - Re: [PATCH v3] firmware/sysfb: Fix VESA format selection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <29c370c79a9775398bcd0f111196f677.squirrel@mail.panix.com>
Date:   Thu, 20 Apr 2023 12:05:28 -0400
From:   "Pierre Asselin" <pa@...ix.com>
To:     "Pierre Asselin" <pa@...ix.com>
Cc:     dri-devel@...ts.freedesktop.org, "Pierre Asselin" <pa@...ix.com>,
        "Javier Martinez Canillas" <javierm@...hat.com>,
        "Thomas Zimmermann" <tzimmermann@...e.de>,
        "Daniel Vetter" <daniel.vetter@...ll.ch>,
        "Ard Biesheuvel" <ardb@...nel.org>,
        "Hans de Goede" <hdegoede@...hat.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] firmware/sysfb: Fix VESA format selection

I went back to nested max3() after all as Thomas asked.  My first cut
had casts in the innermost max3() and the code looked truly awful.  I
decided that two casts are tolerable.  I added a comment to explain
the casts.

Against clamp_t(u8,lfb_depth,1,32): the clamp_t() macro does no
typechecking;  might as well just cast lfb_depth to u8, but that assumes
the value would fit (positively crazy if it doesn't, but still.)
Instead, I widen the other two args of the outer max3().

--PA