[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <168211053800.1750927.15213873309578673308.robh@kernel.org>
Date: Fri, 21 Apr 2023 15:55:38 -0500
From: Rob Herring <robh@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Jarrah Gosbell <kernel@...ef.tools>,
Dmitry Torokhov <dmitry.torokhov@...il.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
devicetree@...r.kernel.org, Rob Herring <robh+dt@...nel.org>,
linux-kernel@...r.kernel.org, linux-input@...r.kernel.org,
Stephen Boyd <sboyd@...nel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>
Subject: Re: [PATCH] dt-bindings: input: touchscreen: goodix: clarify
irq-gpios misleading text
On Wed, 19 Apr 2023 19:18:49 +0200, Luca Ceresoli wrote:
> The irq-gpios description misleading, apparently saying that driving the
> IRQ GPIO resets the device, which is even more puzzling as there is a reset
> GPIO as well.
>
> In reality the IRQ pin can be driven during the reset sequence to configure
> the client address, as it becomes clear after checking both the datasheet
> and the driver code. Improve the text to clarify that.
>
> Also rephrase to remove reference to the driver, which is not appropriate
> in the bindings.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>
> ---
> .../devicetree/bindings/input/touchscreen/goodix.yaml | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@...nel.org>
Powered by blists - more mailing lists