linux-kernel - Re: [PATCH v2 1/2] dt-bindings: regulator: Add support for multiple supplies

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421213659.GA1786000-robh@kernel.org>
Date:   Fri, 21 Apr 2023 16:36:59 -0500
From:   Rob Herring <robh@...nel.org>
To:     Naresh Solanki <naresh.solanki@...ements.com>
Cc:     zev@...ilderbeest.net, Liam Girdwood <lgirdwood@...il.com>,
        Mark Brown <broonie@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-kernel@...r.kernel.org, devicetree@...r.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: regulator: Add support for multiple
 supplies

On Thu, Apr 20, 2023 at 09:24:01PM +0200, Naresh Solanki wrote:
> Add optional DT property 'regulator-supplies' to handle connectors with
> multiple supplies.
> If this property is present, it will determine all regulator supplies.
> Otherwise, the 'vout' supply will be used as a fallback.
> 
> This change improves support for connector like PCIe connectors on
> mainboards that can be powered by 12V and 3.3V supplies.
> 
> Signed-off-by: Naresh Solanki <Naresh.Solanki@...ements.com>
> ...
> Change in V2:
> - Added example
> - Update property type & description.
> - Improve commit message
> ---
>  .../bindings/regulator/regulator-output.yaml  | 21 ++++++++++++++++---
>  1 file changed, 18 insertions(+), 3 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/regulator/regulator-output.yaml b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> index 078b37a1a71a..a9dce26991ff 100644
> --- a/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> +++ b/Documentation/devicetree/bindings/regulator/regulator-output.yaml
> @@ -21,13 +21,22 @@ properties:
>    compatible:
>      const: regulator-output
>  
> -  vout-supply:
> +  regulator-supplies:
> +    $ref: /schemas/types.yaml#/definitions/string-array
>      description:
> -      Phandle of the regulator supplying the output.
> +      Optional property that specifies supply names provided by
> +      the regulator. Defaults to "vout" if not specified. The
> +      array contains a list of supply names.
> +      Each supply name corresponds to a phandle in the
> +      patternProperties.
> +
> +patternProperties:
> +  ".*-supply":
> +    description:
> +      Specifies the phandle for various supplies

While you say use 'vout-supply' for a single supply, nothing enforces 
that anymore.

>  
>  required:
>    - compatible
> -  - vout-supply
>  
>  additionalProperties: false
>  
> @@ -37,3 +46,9 @@ examples:
>            compatible = "regulator-output";
>            vout-supply = <&output_reg>;
>        };
> +      out2 {
> +          compatible = "regulator-output";
> +          regulator-supplies = "sw0", "sw1";
> +          sw0-supply = <&out2_sw0>;
> +          sw1-supply = <&out2_sw1>;

Names in the consumer are relative to the consumer. You appear to be 
naming these by the supplier. Just add vout[0-9]-supply and iterate over 
that name in the driver. Then you don't need "regulator-supplies". 
Really, you never did. You could just find all properties ending in 
"-supply".

Rob