linux-kernel - Re: [PATCH] iommu: amd: Use page mode macros in fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d85e993d-5474-3222-62a9-4489b33d94a0@amd.com>
Date:   Fri, 21 Apr 2023 11:57:57 +0530
From:   Vasant Hegde <vasant.hegde@....com>
To:     Jerry Snitselaar <jsnitsel@...hat.com>, iommu@...ts.linux.dev
Cc:     linux-kernel@...r.kernel.org, Robin Murphy <robin.murphy@....com>,
        Will Deacon <will@...nel.org>,
        Suravee Suthikulpanit <suravee.suthikulpanit@....com>,
        Joerg Roedel <joro@...tes.org>
Subject: Re: [PATCH] iommu: amd: Use page mode macros in fetch_pte

On 4/20/2023 1:37 PM, Jerry Snitselaar wrote:
> Use the page mode macros instead of magic numbers in fetch_pte.
> 
> Cc: Robin Murphy <robin.murphy@....com>
> Cc: Will Deacon <will@...nel.org>
> Cc: Suravee Suthikulpanit <suravee.suthikulpanit@....com>
> Cc: Joerg Roedel <joro@...tes.org>
> Signed-off-by: Jerry Snitselaar <jsnitsel@...hat.com>

Thanks for the fix.

Reviewed-by: Vasant Hegde <vasant.hegde@....com>

-Vasant



> ---
>  drivers/iommu/amd/io_pgtable.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/iommu/amd/io_pgtable.c b/drivers/iommu/amd/io_pgtable.c
> index ace0e9b8b913..61a99d715b23 100644
> --- a/drivers/iommu/amd/io_pgtable.c
> +++ b/drivers/iommu/amd/io_pgtable.c
> @@ -310,8 +310,8 @@ static u64 *fetch_pte(struct amd_io_pgtable *pgtable,
>  			return NULL;
>  
>  		/* Large PTE */
> -		if (PM_PTE_LEVEL(*pte) == 7 ||
> -		    PM_PTE_LEVEL(*pte) == 0)
> +		if (PM_PTE_LEVEL(*pte) == PAGE_MODE_7_LEVEL ||
> +		    PM_PTE_LEVEL(*pte) == PAGE_MODE_NONE)
>  			break;
>  
>  		/* No level skipping support yet */