linux-kernel - Re: [PATCH v10 2/3] mfd: axp20x: Add support for AXP313a PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421073137.GM996918@google.com>
Date:   Fri, 21 Apr 2023 08:31:37 +0100
From:   Lee Jones <lee@...nel.org>
To:     Andre Przywara <andre.przywara@....com>
Cc:     Liam Girdwood <lgirdwood@...il.com>, Chen-Yu Tsai <wens@...e.org>,
        Mark Brown <broonie@...nel.org>,
        Martin Botka <martin.botka@...ainline.org>,
        martin.botka1@...il.com, Shengyu Qu <wiagn233@...look.com>,
        Samuel Holland <samuel@...lland.org>,
        Jernej Skrabec <jernej.skrabec@...il.com>,
        linux-sunxi@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v10 2/3] mfd: axp20x: Add support for AXP313a PMIC

On Sat, 01 Apr 2023, Andre Przywara wrote:

> From: Martin Botka <martin.botka@...ainline.org>
> 
> The AXP313a is a PMIC chip produced by X-Powers, it can be connected via
> an I2C bus.
> The name AXP1530 seems to appear as well, and this is what is used in
> the BSP driver. From all we know it's the same chip, just a different
> name. However we have only seen AXP313a chips in the wild, so go with
> this name.
> 
> Compared to the other AXP PMICs it's a rather simple affair: just three
> DCDC converters, three LDOs, and no battery charging support.
> 
> Describe the regmap and the MFD bits, along with the registers exposed
> via I2C. Aside from the various regulators, also describe the power key
> interrupts, and adjust the shutdown handler routine to use a different
> register than the other PMICs.
> Eventually advertise the device using the new compatible string.
> 
> Signed-off-by: Martin Botka <martin.botka@...ainline.org>
> Signed-off-by: Andre Przywara <andre.przywara@....com>
> Acked-for-MFD-by: Lee Jones <lee@...nel.org>
> ---
>  drivers/mfd/axp20x-i2c.c   |  2 +
>  drivers/mfd/axp20x.c       | 78 +++++++++++++++++++++++++++++++++++++-
>  include/linux/mfd/axp20x.h | 32 ++++++++++++++++
>  3 files changed, 111 insertions(+), 1 deletion(-)

Applied, thanks.

-- 
Lee Jones [李琼斯]