linux-kernel - Re: [PATCH] media: ov5693: Simplify an error message

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b4aea4b5-d86a-1604-c646-346ea7b59476@gentoo.org>
Date:   Fri, 21 Apr 2023 09:38:21 +0200
From:   Matthias Schwarzott <zzam@...too.org>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Daniel Scally <djrscally@...il.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>
Cc:     linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        linux-media@...r.kernel.org
Subject: Re: [PATCH] media: ov5693: Simplify an error message

Am 15.04.23 um 18:28 schrieb Christophe JAILLET:
> dev_err_probe() already display the error code. There is no need to
> duplicate it explicitly in the error message.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
>   drivers/media/i2c/ov5693.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/i2c/ov5693.c b/drivers/media/i2c/ov5693.c
> index e3c3bed69ad6..d23786afd754 100644
> --- a/drivers/media/i2c/ov5693.c
> +++ b/drivers/media/i2c/ov5693.c
> @@ -404,8 +404,8 @@ static int ov5693_read_reg(struct ov5693_device *ov5693, u32 addr, u32 *value)
>   	ret = i2c_transfer(client->adapter, msg, 2);
>   	if (ret < 0)

i2c_transfer returns the number of transmitted messages. So I think the 
values 0 <= ret < 2 also need to be handled.

>   		return dev_err_probe(&client->dev, ret,
> -				     "Failed to read register 0x%04x: %d\n",
> -				     addr & OV5693_REG_ADDR_MASK, ret);
> +				     "Failed to read register 0x%04x\n",
> +				     addr & OV5693_REG_ADDR_MASK);
>   
>   	*value = 0;
>   	for (i = 0; i < len; ++i) {