linux-kernel - Re: [PATCH v3 2/3] pinctrl: tps6594: add for TPS6594 PMIC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdab_26D9BMGeSygy_oa6SFa62ytXcy+Ydi3yPzQO3tU4A@mail.gmail.com>
Date:   Fri, 21 Apr 2023 10:34:34 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Esteban Blanc <eblanc@...libre.com>
Cc:     lgirdwood@...il.com, broonie@...nel.org, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, linux-kernel@...r.kernel.org,
        linux-gpio@...r.kernel.org, linux-rtc@...r.kernel.org,
        jpanis@...libre.com, jneanne@...libre.com, aseketeli@...libre.com,
        sterzik@...com, u-kumar1@...com
Subject: Re: [PATCH v3 2/3] pinctrl: tps6594: add for TPS6594 PMIC

Hi Esteban,

thanks for your patch!

On Fri, Apr 14, 2023 at 12:12 PM Esteban Blanc <eblanc@...libre.com> wrote:

> TI TPS6594 PMIC has 11 GPIOs which can be used for different
> functions.
>
> This add a pinctrl and pinmux drivers in order to use those functions.
>
> Signed-off-by: Esteban Blanc <eblanc@...libre.com>
(...)
> +config PINCTRL_TPS6594
> +       tristate "Pinctrl and GPIO driver for TI TPS6594 PMIC"
> +       depends on MFD_TPS6594
> +       default MFD_TPS6594
> +       select PINMUX
> +       select GPIOLIB

select GPIO_REGMAP
?

I think this driver can use the GPIO_REGMAP helper library.

Please look into other drivers using this, such as
drivers/gpio/gpio-sl28cpld.c

Yours,
Linus Walleij