linux-kernel - Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421092742.jjr4gnkswj22yt76@bogus>
Date:   Fri, 21 Apr 2023 10:27:42 +0100
From:   Sudeep Holla <sudeep.holla@....com>
To:     Cristian Marussi <cristian.marussi@....com>
Cc:     Tejun Heo <tj@...nel.org>, linux-arm-kernel@...ts.infradead.org,
        Sudeep Holla <sudeep.holla@....com>,
        linux-kernel@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH] firmware: arm_scmi: Fix incorrect alloc_workqueue()
 invocation

On Fri, Apr 21, 2023 at 09:46:11AM +0100, Cristian Marussi wrote:
> On Thu, Apr 20, 2023 at 09:33:49AM -1000, Tejun Heo wrote:
> > scmi_xfer_raw_worker_init() is specifying a flag, WQ_SYSFS, as @max_active.
> > Fix it by or'ing WQ_SYSFS into @flags so that it actually enables sysfs
> > interface and using 0 for @max_active for the default setting.
> >

Thanks, good catch, very hard to notice.

> 
> Hi Tejun,
> 
> my bad I messed up the params in the call.
>

Hi Cristian,

I think it deserves the fixes tag, right ?

Fixes: 3c3d818a9317 ("firmware: arm_scmi: Add core raw transmission support")

-- 
Regards,
Sudeep