linux-kernel - Re: [PATCH v2] iio: light: al3320a: Handle ACPI device CALS0001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2023 11:36:51 +0200
From:   Hans de Goede <hdegoede@...hat.com>
To:     Marius Hoch <mail@...iushoch.de>,
        Jonathan Cameron <jic23@...nel.org>,
        Lars-Peter Clausen <lars@...afoo.de>,
        linux-iio@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] iio: light: al3320a: Handle ACPI device CALS0001

Hi,

On 4/21/23 01:26, Marius Hoch wrote:
> This sensor can be found as CALS0001 on the Lenovo Yoga
> Tablet 2 series.
> 
> Tested on a Lenovo Yoga Tablet 2 1051-F.
> 
> Signed-off-by: Marius Hoch <mail@...iushoch.de>
> ---
> v2: Explicitly include <linux/mod_devicetable.h> (don't rely on
> linux/i2c.h including it)

Thanks, the patch looks good to me and I have
tested this successfully on a Lenovo Yoga Tablet 2 851F :

Tested-by: Hans de Goede <hdegoede@...hat.com>
Reviewed-by: Hans de Goede <hdegoede@...hat.com>

Regards,

Hans




> ---
>  drivers/iio/light/al3320a.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c
> index 9ff28bbf34bb..36214d790f71 100644
> --- a/drivers/iio/light/al3320a.c
> +++ b/drivers/iio/light/al3320a.c
> @@ -16,6 +16,7 @@
>  #include <linux/i2c.h>
>  #include <linux/module.h>
>  #include <linux/of.h>
> +#include <linux/mod_devicetable.h>
>  
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> @@ -247,11 +248,18 @@ static const struct of_device_id al3320a_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, al3320a_of_match);
>  
> +static const struct acpi_device_id al3320a_acpi_match[] = {
> +	{"CALS0001"},
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(acpi, al3320a_acpi_match);
> +
>  static struct i2c_driver al3320a_driver = {
>  	.driver = {
>  		.name = AL3320A_DRV_NAME,
>  		.of_match_table = al3320a_of_match,
>  		.pm = pm_sleep_ptr(&al3320a_pm_ops),
> +		.acpi_match_table = al3320a_acpi_match,
>  	},
>  	.probe_new	= al3320a_probe,
>  	.id_table	= al3320a_id,
> 
> base-commit: cb0856346a60fe3eb837ba5e73588a41f81ac05f