linux-kernel - Re: [PATCH v2] sh: Replace <uapi/asm/types.h> by <asm-generic/int-ll64.h>

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <cfcfc689de8480a3ab0a03826e4c95f22c5af937.camel@physik.fu-berlin.de>
Date:   Fri, 21 Apr 2023 13:14:13 +0200
From:   John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>,
        Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>
Cc:     linux-sh@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] sh: Replace <uapi/asm/types.h> by
 <asm-generic/int-ll64.h>

Hi Geert!

On Thu, 2023-03-23 at 11:22 +0100, Geert Uytterhoeven wrote:
> As arch/sh/include/uapi/asm/types.h doesn't exist, sh doesn't provide
> any sh-specific uapi definitions, and it can just include
> <asm-generic/int-ll64.h>, like most other architectures.
> 
> Signed-off-by: Geert Uytterhoeven <geert@...ux-m68k.org>
> ---
> v2:
>   - Rebased for SPDX-License-Identifier addition in 2017.
> 
>  arch/sh/include/asm/types.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/sh/include/asm/types.h b/arch/sh/include/asm/types.h
> index 68eb24ad201383ef..9b3fc923ee28701c 100644
> --- a/arch/sh/include/asm/types.h
> +++ b/arch/sh/include/asm/types.h
> @@ -2,7 +2,7 @@
>  #ifndef __ASM_SH_TYPES_H
>  #define __ASM_SH_TYPES_H
>  
> -#include <uapi/asm/types.h>
> +#include <asm-generic/int-ll64.h>
>  
>  /*
>   * These aren't exported outside the kernel to avoid name space clashes

It seems that many (most?) architectures don't even provide their own types.h
header. Does it even make sense to still carry that header or can it be provided
from somewhere else?

Adrian

-- 
 .''`.  John Paul Adrian Glaubitz
: :' :  Debian Developer
`. `'   Physicist
  `-    GPG: 62FF 8A75 84E0 2956 9546  0006 7426 3B37 F5B5 F913