linux-kernel - RE: [PATCH v1] usb: phy: add usb phy notify port status API

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eecf54cdc06a4e3690e2cad62a8d4596@realtek.com>
Date:   Fri, 21 Apr 2023 11:19:40 +0000
From:   Stanley Chang[昌育德] 
        <stanley_chang@...ltek.com>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
CC:     Alan Stern <stern@...land.harvard.edu>,
        Douglas Anderson <dianders@...omium.org>,
        Vincent Mailhol <mailhol.vincent@...adoo.fr>,
        Bhuvanesh Surachari <Bhuvanesh_Surachari@...tor.com>,
        Mathias Nyman <mathias.nyman@...ux.intel.com>,
        Flavio Suligoi <f.suligoi@...m.it>,
        Ray Chi <raychi@...gle.com>,
        Michael Grzeschik <m.grzeschik@...gutronix.de>,
        "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v1] usb: phy: add usb phy notify port status API

> > > We can not add callbacks in the kernel that are not actually used,
> > > otherwise they will just be instantly removed.
> > >
> > > Please submit any drivers that need this change at the same time so
> > > that we can verify that the callback is actually correct and needed,
> > > otherwise we can not take this change.
> > >
> >
> > In this stage, we usb phy driver is not at linux upstream.
> 
> Then obviously we can not take this change (nor would you want us to.)

I will prepare a complete driver for review.

> > For the android GKI, we have to add this callback to upstream or use the
> vendor hook of android.
> > I will plan to upstream the realtek usb phy driver.
> 
> As you already have this driver, why not send it to us now?
> 
Now the driver doesn't match the coding style.
After I refactor it, I will send this driver upstream.

Thanks,
Stanley