[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <bec64668-f6bf-c41a-58b2-6ca25b1b3668@linaro.org>
Date: Fri, 21 Apr 2023 13:53:00 +0200
From: Konrad Dybcio <konrad.dybcio@...aro.org>
To: Dan Carpenter <dan.carpenter@...aro.org>,
Loic Poulain <loic.poulain@...aro.org>
Cc: Andy Gross <agross@...nel.org>,
Bjorn Andersson <andersson@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
kernel-janitors@...r.kernel.org
Subject: Re: [PATCH] soc: qcom: rmtfs: Fix error code in probe()
On 21.04.2023 12:44, Dan Carpenter wrote:
> Return an error code if of_property_count_u32_elems() fails. Don't
> return success.
>
> Fixes: e656cd0bcf3d ("soc: qcom: rmtfs: Optionally map RMTFS to more VMs")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>
> ---
Reviewed-by: Konrad Dybcio <konrad.dybcio@...aro.org>
Konrad
> drivers/soc/qcom/rmtfs_mem.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/qcom/rmtfs_mem.c b/drivers/soc/qcom/rmtfs_mem.c
> index ce48a9f3b4c8..f83811f51175 100644
> --- a/drivers/soc/qcom/rmtfs_mem.c
> +++ b/drivers/soc/qcom/rmtfs_mem.c
> @@ -233,6 +233,7 @@ static int qcom_rmtfs_mem_probe(struct platform_device *pdev)
> num_vmids = 0;
> } else if (num_vmids < 0) {
> dev_err(&pdev->dev, "failed to count qcom,vmid elements: %d\n", num_vmids);
> + ret = num_vmids;
> goto remove_cdev;
> } else if (num_vmids > NUM_MAX_VMIDS) {
> dev_warn(&pdev->dev,
Powered by blists - more mailing lists