linux-kernel - [PATCH 0/4] pinctrl: amd: Adjust handling for firmware misconfigurations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230421120625.3366-1-mario.limonciello@amd.com>
Date:   Fri, 21 Apr 2023 07:06:20 -0500
From:   Mario Limonciello <mario.limonciello@....com>
To:     <linus.walleij@...aro.org>, <linux-gpio@...r.kernel.org>
CC:     <nakato@...ato.io>, <korneld@...omium.org>, <richard.gong@....com>,
        <Shyam-sundar.S-k@....com>, <Basavaraj.Natikar@....com>,
        Mario Limonciello <mario.limonciello@....com>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH 0/4] pinctrl: amd: Adjust handling for firmware misconfigurations

commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe")
had intended to work around firmware problems on a Microsoft Surface
device but actually masked other real bugs in firmware and the driver.

Before this commit, "wake on lid" doesn't work properly on a number of
systems, but this is because debounce handling was improperly configured
in the driver and due to a bug in this commit it gets configured a
different way.

commit b26cd9325be4 ("pinctrl: amd: Disable and mask interrupts on
resume") attempted to build on top of this to mask issues on resume, but
it happened to "fix" the bug in commit 4e5a04be88fe ("pinctrl: amd:
disable and mask interrupts on probe") which "broke" wake on lid since
the debounce handling was programmed differently.

This was reverted in commit 534e465845eb ("Revert "pinctrl: amd: Disable
and mask interrupts on resume"") which fixed the wake on lid.

To fix this series of unfortunate events and prevent them in the future
this series corrects the GPIO0 debounce handling and reverts commit
4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe"). A new
patch that is safer is included that will fix spurious interrupt handling
and is expected to fix the issues that both
commit 4e5a04be88fe ("pinctrl: amd: disable and mask interrupts on probe")
and
commit b26cd9325be4 ("pinctrl: amd: Disable and mask interrupts on
resume") attempted to fix in a more scalable way.

Kornel Dulęba (1):
  pinctrl: amd: Detect and mask spurious interrupts

Mario Limonciello (3):
  pinctrl: amd: Detect internal GPIO0 debounce handling
  pinctrl: amd: Fix mistake in handling clearing pins at startup
  pinctrl: amd: Revert "pinctrl: amd: disable and mask interrupts on
    probe"

 drivers/pinctrl/pinctrl-amd.c | 50 +++++++++--------------------------
 drivers/pinctrl/pinctrl-amd.h |  1 +
 2 files changed, 14 insertions(+), 37 deletions(-)

-- 
2.34.1