linux-kernel - Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b031f528-f3dd-44ed-5370-2133a74f9332@kernel.org>
Date:   Fri, 21 Apr 2023 10:27:40 +0800
From:   Chao Yu <chao@...nel.org>
To:     Qi Han <hanqi@...o.com>, jaegeuk@...nel.org
Cc:     linux-f2fs-devel@...ts.sourceforge.net,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] f2fs: remove unnessary comment in __may_age_extent_tree

On 2023/4/18 14:09, Qi Han wrote:
> This comment make no sense and is in the wrong place, so let's
> remove it.
> 
> Signed-off-by: Qi Han <hanqi@...o.com>
> ---
>   fs/f2fs/extent_cache.c | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/fs/f2fs/extent_cache.c b/fs/f2fs/extent_cache.c
> index 28b12553f2b3..1f6d7de35794 100644
> --- a/fs/f2fs/extent_cache.c
> +++ b/fs/f2fs/extent_cache.c
> @@ -86,7 +86,6 @@ static bool __may_age_extent_tree(struct inode *inode)
>   
>   	if (!test_opt(sbi, AGE_EXTENT_CACHE))
>   		return false;
> -	/* don't cache block age info for cold file */
>   	if (is_inode_flag_set(inode, FI_COMPRESSED_FILE))
>   		return false;

Should move it here instead of removal?

/* don't cache block age info for cold file */

>   	if (file_is_cold(inode))