linux-kernel - Re: [PATCH v3] sh: Use generic GCC library routines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAMuHMdW72T=OU0iEtbAjHqYUv_k0+xe8NeUod4BhzNTUqoPH6A@mail.gmail.com>
Date:   Fri, 21 Apr 2023 14:14:22 +0200
From:   Geert Uytterhoeven <geert@...ux-m68k.org>
To:     John Paul Adrian Glaubitz <glaubitz@...sik.fu-berlin.de>
Cc:     Yoshinori Sato <ysato@...rs.sourceforge.jp>,
        Rich Felker <dalias@...c.org>,
        Palmer Dabbelt <palmer@...osinc.com>, linux-sh@...r.kernel.org,
        linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] sh: Use generic GCC library routines

Hi Adrian,

On Fri, Apr 21, 2023 at 1:03 PM John Paul Adrian Glaubitz
<glaubitz@...sik.fu-berlin.de> wrote:
> On Thu, 2023-03-23 at 11:18 +0100, Geert Uytterhoeven wrote:
> > The C implementations of __ashldi3(), __ashrdi3__(), and __lshrdi3() in
> > arch/sh/lib/ are identical to the generic C implementations in lib/.
> > Reduce duplication by switching SH to the generic versions.
> >
> > Update the include path in arch/sh/boot/compressed accordingly.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@...der.be>
> > Acked-by: Palmer Dabbelt <palmer@...osinc.com>

> > --- a/arch/sh/lib/Makefile
> > +++ b/arch/sh/lib/Makefile
> > @@ -7,9 +7,7 @@ lib-y  = delay.o memmove.o memchr.o \
> >        checksum.o strlen.o div64.o div64-generic.o
> >
> >  # Extracted from libgcc
> > -obj-y += movmem.o ashldi3.o ashrdi3.o lshrdi3.o \
> > -      ashlsi3.o ashrsi3.o ashiftrt.o lshrsi3.o \
> > -      udiv_qrnnd.o
> > +obj-y += movmem.o ashlsi3.o ashrsi3.o ashiftrt.o lshrsi3.o udiv_qrnnd.o
>
> Why are the single-precision (denoted as "si") variants not being replaced?
>
> Don't we have generic versions for these?

Because they are written in assembler, and thus different from generic
versions, and because Linux does not include generic versions for these.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds