[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZEKgHNlykqw7LmKm@ziepe.ca>
Date: Fri, 21 Apr 2023 11:39:24 -0300
From: Jason Gunthorpe <jgg@...pe.ca>
To: "Saleem, Shiraz" <shiraz.saleem@...el.com>
Cc: Tejun Heo <tj@...nel.org>,
"Ismail, Mustafa" <mustafa.ismail@...el.com>,
Leon Romanovsky <leon@...nel.org>,
"linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"kernel-team@...com" <kernel-team@...com>
Subject: Re: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
alloc_ordered_workqueue() call
On Fri, Apr 21, 2023 at 02:29:06PM +0000, Saleem, Shiraz wrote:
> > Subject: [PATCH] RDMA/irdma: Drop spurious WQ_UNBOUND from
> > alloc_ordered_workqueue() call
> >
> > Workqueue is in the process of cleaning up the distinction between unbound
> > workqueues w/ @nr_active==1 and ordered workqueues. Explicit
> > WQ_UNBOUND isn't needed for alloc_ordered_workqueue() and will trigger a
> > warning in the future. Let's remove it. This doesn't cause any functional
> > changes.
> >
> > Signed-off-by: Tejun Heo <tj@...nel.org>
> > ---
> > drivers/infiniband/hw/irdma/hw.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > --- a/drivers/infiniband/hw/irdma/hw.c
> > +++ b/drivers/infiniband/hw/irdma/hw.c
> > @@ -1901,8 +1901,8 @@ int irdma_ctrl_init_hw(struct irdma_pci_
> > break;
> > rf->init_state = CEQ0_CREATED;
> > /* Handles processing of CQP completions */
> > - rf->cqp_cmpl_wq = alloc_ordered_workqueue("cqp_cmpl_wq",
> > - WQ_HIGHPRI |
> > WQ_UNBOUND);
> > + rf->cqp_cmpl_wq =
> > + alloc_ordered_workqueue("cqp_cmpl_wq",
> > WQ_HIGHPRI);
> > if (!rf->cqp_cmpl_wq) {
> > status = -ENOMEM;
> > break;
>
> Acked-by: Shiraz Saleem <shiraz.saleem@...el.com>
Tejun, do you want this in your tree too?
Thanks
Jason
Powered by blists - more mailing lists