[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZEKno++WWPauufw0@gmail.com>
Date: Fri, 21 Apr 2023 08:11:31 -0700
From: Breno Leitao <leitao@...ian.org>
To: Christoph Hellwig <hch@....de>
Cc: io-uring@...r.kernel.org, linux-nvme@...ts.infradead.org,
asml.silence@...il.com, axboe@...nel.dk, leit@...com,
linux-kernel@...r.kernel.org, linux-block@...r.kernel.org,
sagi@...mberg.me, kbusch@...nel.org, ming.lei@...hat.com
Subject: Re: [PATCH 1/2] io_uring: Pass whole sqe to commands
On Thu, Apr 20, 2023 at 06:57:12AM +0200, Christoph Hellwig wrote:
> On Wed, Apr 19, 2023 at 03:29:29AM -0700, Breno Leitao wrote:
> > struct nvme_uring_cmd_pdu *pdu = nvme_uring_cmd_pdu(ioucmd);
> > - const struct nvme_uring_cmd *cmd = ioucmd->cmd;
> > + const struct nvme_uring_cmd *cmd = (struct nvme_uring_cmd *)ioucmd->sqe->cmd;
>
> Please don't add the pointless cast. And in general avoid the overly
> long lines.
If I don't add this cast, the compiler complains with the follow error:
drivers/nvme/host/ioctl.c: In function ‘nvme_uring_cmd_io’:
drivers/nvme/host/ioctl.c:555:37: error: initialization of ‘const struct nvme_uring_cmd *’ from incompatible pointer type ‘const __u8 *’ {aka ‘const unsigned char *’} [-Werror=incompatible-pointer-types]
const struct nvme_uring_cmd *cmd = ioucmd->sqe->cmd;
Powered by blists - more mailing lists