lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date:   Fri, 21 Apr 2023 09:11:25 -0700
From:   Nathan Chancellor <nathan@...nel.org>
To:     tsbogend@...ha.franken.de
Cc:     ndesaulniers@...gle.com, linux-mips@...r.kernel.org,
        linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
        patches@...ts.linux.dev,
        Naresh Kamboju <naresh.kamboju@...aro.org>,
        Nathan Chancellor <nathan@...nel.org>
Subject: [PATCH v2 0/2] MIPS: Fix check_bugs() modpost warning

Hi all,

This series fixes a modpost warning visible in -next from check_bugs()
and helps avoid a potential, albeit unlikely, warning from
check_bugs_early().

---
Changes in v2:
- Now two separate patches: one to avoid current check_bugs() warning
  and one to avoid potential check_bugs_early() warning.
- Sink body of check_bugs_early() into setup_arch() directly, rather
  than marking it as __init (Nick).
- Add Naresh's reported-by to patch 1, which came after v1 was sent.
- Reword commit messages to note that there is not a problem at run time
  because check_bugs() and check_bugs_early(), while not marked __init,
  are only called from __init functions; modpost does not know this
  though, hence the warning.
- Link to v1: https://lore.kernel.org/r/20230419-mips-check_bugs-init-attribute-v1-1-91e6eed55b89@kernel.org

---
Nathan Chancellor (2):
      MIPS: Mark check_bugs() as __init
      MIPS: Sink body of check_bugs_early() into its only call site

 arch/mips/include/asm/bugs.h | 8 +-------
 arch/mips/kernel/setup.c     | 3 ++-
 2 files changed, 3 insertions(+), 8 deletions(-)
---
base-commit: 6a8f57ae2eb07ab39a6f0ccad60c760743051026
change-id: 20230419-mips-check_bugs-init-attribute-026103bdb255

Best regards,
-- 
Nathan Chancellor <nathan@...nel.org>

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ