linux-kernel - Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support for InnoLux G070ACE-L01

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 21 Apr 2023 09:37:15 -0700
From:   Doug Anderson <dianders@...omium.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
Cc:     richard.leitner@...ux.dev,
        Thierry Reding <thierry.reding@...il.com>,
        Sam Ravnborg <sam@...nborg.org>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org,
        Richard Leitner <richard.leitner@...data.com>
Subject: Re: [PATCH RESEND v2 1/2] dt-bindings: display: simple: add support
 for InnoLux G070ACE-L01

Hi,

On Fri, Apr 21, 2023 at 9:26 AM Krzysztof Kozlowski
<krzysztof.kozlowski@...aro.org> wrote:
>
> On 21/04/2023 18:15, Doug Anderson wrote:
> > Hi,
> >
> > On Mon, Mar 13, 2023 at 12:51 AM <richard.leitner@...ux.dev> wrote:
> >>
> >> From: Richard Leitner <richard.leitner@...data.com>
> >>
> >> Add Innolux G070ACE-L01 7" WVGA (800x480) TFT LCD panel compatible
> >> string.
> >>
> >> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> >> Signed-off-by: Richard Leitner <richard.leitner@...data.com>
> >
> > nit: as I understand it, ordering of tags is usually supposed to be
> > chronological. You signed off on this patch before Krzysztof acked it,
> > so the SoB should be above. I'll fix that when applying.
>
> Some people agree with this... but b4 disagrees, so I would say the
> tools should implement the right process and right decisions. We should
> not be correcting the tools' output, unless the tools are not correct -
> then fix the tools.

Ah, interesting. I checked and as far as I could tell Richard had
manually added the tag when sending v2, so I didn't assume it as a
tool-added tag. I'm happy to let "b4" be the canonical thing that says
what the order should be.

OK, so I just tried this and I'm confused. I ran:

b4 am -P_ 20230201-innolux-g070ace-v2-2-2371e251dd40@...data.com

...and when I check the patch that b4 spits out my "Reviewed-by" tag
is _after_ the "Signed-off-by" tag, just like I asked for.

Just in case Acked-by was somehow different than Reviewed-by, I went
back to the original version where you added the Acked-by:

 b4 am -P_ 20221118075856.401373-1-richard.leitner@...ux.dev

...and, again, it matches the order that I thought was right. In other
words, the patch file generated says:

> Signed-off-by: Richard Leitner <richard.leitner@...data.com>
> Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

My "b4" is from Dec 1 of last year, so maybe something changed? Let's
update! OK, I synced b4 and now I'm at v0.12.2 from Match 10 (MARIO
day!). The behavior is unchanged.

Did I get something wrong in the above?