linux-kernel - Re: [PATCH 1/1] ufs: core: fix &hwq->cq

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8e4a9151-10e3-28a4-3263-25e67437ffbe@acm.org>
Date:   Fri, 21 Apr 2023 10:25:48 -0700
From:   Bart Van Assche <bvanassche@....org>
To:     Alice Chao <alice.chao@...iatek.com>, alim.akhtar@...sung.com,
        avri.altman@....com, jejb@...ux.ibm.com,
        martin.petersen@...cle.com, matthias.bgg@...il.com,
        angelogioacchino.delregno@...labora.com, quic_asutoshd@...cinc.com,
        quic_cang@...cinc.com, mani@...nel.org, linux-scsi@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org
Cc:     stanley.chu@...iatek.com, peter.wang@...iatek.com,
        chun-hung.wu@...iatek.com, powen.kao@...iatek.com,
        naomi.chu@...iatek.com, cc.chou@...iatek.com,
        chaotian.jing@...iatek.com, jiajie.hao@...iatek.com,
        tun-yu.yu@...iatek.com, eddie.huang@...iatek.com,
        wsd_upstream@...iatek.com
Subject: Re: [PATCH 1/1] ufs: core: fix &hwq->cq_lock deadlock issue

On 4/21/23 00:56, Alice Chao wrote:
> When ufshcd_err_handler() is executed, CQ event interrupt can enter
> waiting for the same lock. It could happened in upstream code path
> ufshcd_handle_mcq_cq_events() and also in ufs_mtk_mcq_intr(). This
> warning message will be generated when &hwq->cq_lock is used in IRQ
> context with IRQ enabled. Use ufshcd_mcq_poll_cqe_lock() with
> spin_lock_irqsave instead of spin_lock to resolve the deadlock issue.

Please add a Fixes: tag.

Thanks,

Bart.