linux-kernel - Re: [PATCH] drm/msm/dp: unregister audio driver during unbind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7579b02e-5b4d-72b7-4cef-e18f9fc86d7d@quicinc.com>
Date:   Fri, 21 Apr 2023 11:41:59 -0700
From:   Abhinav Kumar <quic_abhinavk@...cinc.com>
To:     Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        <robdclark@...il.com>, <sean@...rly.run>,
        <dmitry.baryshkov@...aro.org>, <airlied@...il.com>,
        <daniel@...ll.ch>, <lyude@...hat.com>
CC:     <javierm@...hat.com>, <tzimmermann@...e.de>,
        <quic_khsieh@...cinc.com>, <quic_bjorande@...cinc.com>,
        <johan+linaro@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] drm/msm/dp: unregister audio driver during unbind



On 4/21/2023 7:56 AM, Srinivas Kandagatla wrote:
> while binding the code always registers a audio driver, however there
> is no corresponding unregistration done in unbind. This leads to multiple
> redundant audio platform devices if dp_display_bind and dp_display_unbind
> happens multiple times during startup. On X13s platform this resulted in
> 6 to 9 audio codec device instead of just 3 codec devices for 3 dp ports.
> 
> Fix this by unregistering codecs on unbind.
> 
> Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> ---

Fixes: d13e36d7d222 ("drm/msm/dp: add audio support for Display Port on 
MSM")

Reviewed-by: Abhinav Kumar <quic_abhinavk@...cinc.com>

(pls ignore the line break in the fixes tag, its a mail editor issue, I 
will apply the tag properly while applying to -fixes)