linux-kernel - Re: [PATCH 2/2] kbuild: deb-pkg: add KDEB_SOURCE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3a5c0f51d120bb11cb5fdf9b7e2925d8a5c1dbe2.camel@decadent.org.uk>
Date:   Sat, 22 Apr 2023 13:04:32 +0200
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Masahiro Yamada <masahiroy@...nel.org>,
        Nicolas Schier <nicolas@...sle.eu>
Cc:     linux-kbuild@...r.kernel.org, linux-kernel@...r.kernel.org,
        Bastian Germann <bage@...utronix.de>,
        Nathan Chancellor <nathan@...nel.org>,
        Nick Desaulniers <ndesaulniers@...gle.com>
Subject: Re: [PATCH 2/2] kbuild: deb-pkg: add KDEB_SOURCE_COMPRESS to
 specify compression type

On Thu, 2023-04-20 at 16:17 +0900, Masahiro Yamada wrote:
> On Thu, Apr 20, 2023 at 5:34 AM Nicolas Schier <nicolas@...sle.eu> wrote:
[...]
> > > +KDEB_SOURCE_COMPRESS ?= gzip
> > 
> > According to dpkg-source(1), xz is the default compression for deb
> > source format >= 2.  Shouldn't we use xz here by default as well?
> 
> 
> Yes.
> xz is the default because we switched to format 3.0 (quilt).
> 
> But, we used gzip for a long time, so I did not change it
> in this commit.
> 
> 
> I do not have a strong opinion.
> 
> Ben (debian kernel maintainer) is in the CC list,
> perhaps he has some preference.

I think it makes sense to keep source compression unchanged in this
commit, but you could add another commit to change the default.

Ben.

-- 
Ben Hutchings
Theory and practice are closer in theory than in practice - John Levine

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)