linux-kernel - Re: [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config based connection profile in NM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230422135516.70a63d96.olaf@aepfle.de>
Date:   Sat, 22 Apr 2023 13:55:16 +0200
From:   Olaf Hering <olaf@...fle.de>
To:     Shradha Gupta <shradhagupta@...ux.microsoft.com>
Cc:     linux-kernel@...r.kernel.org, linux-hyperv@...r.kernel.org,
        "K. Y. Srinivasan" <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Wei Liu <wei.liu@...nel.org>, Dexuan Cui <decui@...rosoft.com>,
        Long Li <longli@...rosoft.com>,
        Michael Kelley <mikelley@...rosoft.com>
Subject: Re: [PATCH v2] hv/hv_kvp_daemon: Add support for keyfile config
 based  connection profile in NM

Sat, 22 Apr 2023 01:39:43 -0700 Shradha Gupta <shradhagupta@...ux.microsoft.com>:

> The next part of this support is to let the Distro vendors consume
> these modified implementations to the new configuration format.

The approach taken here makes it difficult to consume the changes.
The way it is implemented means a given variant of the daemon produces
either ifcfg or .nmconnection files. In practice there is a single
source of hv_kvp_daemon.c which is compatible with all versions of a distro.

IMO the new feature should be implemented such that hv_kvp_daemon 
writes both files. Then the tooling can decide which of the files will
actually be used.

I think the configuration file for NetworkManager should have the
suffix .nmconnection, even if it may not be mandatory.

Olaf

Content of type "application/pgp-signature" skipped