linux-kernel - Re: [PATCH 3/3] arm64: dts: qcom: msm8992-libra: drop duplicated reserved memory

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <99b71397-9d51-4cfa-533b-992369b74541@linaro.org>
Date:   Sat, 22 Apr 2023 14:20:16 +0200
From:   Konrad Dybcio <konrad.dybcio@...aro.org>
To:     Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
        Andy Gross <agross@...nel.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Rob Herring <robh+dt@...nel.org>,
        Krzysztof Kozlowski <krzysztof.kozlowski+dt@...aro.org>,
        linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] arm64: dts: qcom: msm8992-libra: drop duplicated
 reserved memory



On 20.04.2023 20:07, Krzysztof Kozlowski wrote:
> There are two entries for similar reserved memory: qseecom@...00000 and
> audio@...00000.  Keep the qseecom as it is longer.
> 
>   Warning (unique_unit_address_if_enabled): /reserved-memory/audio@...00000: duplicate unit-address (also used in node /reserved-memory/qseecom@...00000)
> 
> Fixes: 69876bc6fd4d ("arm64: dts: qcom: msm8992-libra: Fix the memory map")
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> 
> ---
> 
> Maybe the original intention was to use different address for audio res.
> memory?
> ---
Similar story to patch 2, I'll recheck on a device
soon(tm)

Konrad
>  arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> index 501e05efbef4..133f9c2540bc 100644
> --- a/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> +++ b/arch/arm64/boot/dts/qcom/msm8992-xiaomi-libra.dts
> @@ -110,11 +110,6 @@ rmtfs_mem: rmtfs@...00000 {
>  			qcom,client-id = <1>;
>  		};
>  
> -		audio_mem: audio@...00000 {
> -			reg = <0 0xcb000000 0 0x400000>;
> -			no-mem;
> -		};
> -
>  		qseecom_mem: qseecom@...00000 {
>  			reg = <0 0xcb400000 0 0x1c00000>;
>  			no-mem;