linux-kernel - Re: [PATCH] tools/counter: Makefile: Remove useless 'include' when make clean

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZEPrLfRajOjhv52l@fedora>
Date:   Sat, 22 Apr 2023 10:11:57 -0400
From:   William Breathitt Gray <william.gray@...aro.org>
To:     Rong Tao <rtoax@...mail.com>
Cc:     rongtao@...tc.cn,
        "open list:COUNTER SUBSYSTEM" <linux-iio@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] tools/counter: Makefile: Remove useless 'include' when
 make clean

Hi Rong,

This is a nitpick, but I think the word "lingering" is better than
"useless" for the title.

On Fri, Apr 21, 2023 at 07:47:25PM +0800, Rong Tao wrote:
> From: Rong Tao <rongtao@...tc.cn>
> 
> 'make' create 'include' directory, we should remove it when 'make clean'.

There are a few typos here, so I think you mean something like this:

    'make' creates the 'include' directory, so we should remove it on
    'make clean'.

> 
> Signed-off-by: Rong Tao <rongtao@...tc.cn>
> ---
>  tools/counter/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/counter/Makefile b/tools/counter/Makefile
> index 8843f0fa6119..e2475a1f10d8 100644
> --- a/tools/counter/Makefile
> +++ b/tools/counter/Makefile
> @@ -39,7 +39,7 @@ $(OUTPUT)counter_example: $(COUNTER_EXAMPLE)
>  
>  clean:
>  	rm -f $(ALL_PROGRAMS)
> -	rm -rf $(OUTPUT)include/linux/counter.h
> +	rm -rf $(OUTPUT)include

The Makefile actually first creates the 'include/linux' directory via
the `mkdir -p` command, and then creates a symbolic link for
'include/linux/counter.h'. It would be more appropriate instead to
unroll these actions here in the `clean` section:

    rm -rf $(OUTPUT)include/linux/counter.h
    rmdir -p $(OUTPUT)include/linux

William Breathitt Gray

>  	find $(or $(OUTPUT),.) -name '*.o' -delete -o -name '\.*.d' -delete
>  
>  install: $(ALL_PROGRAMS)
> -- 
> 2.40.0
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)