linux-kernel - Re: [PATCH v2 01/24] selftests/resctrl: Add resctrl.h into build deps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a1c85bef-5f41-c49b-a012-1e75e69a3789@intel.com>
Date:   Fri, 21 Apr 2023 17:07:55 -0700
From:   Reinette Chatre <reinette.chatre@...el.com>
To:     Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
        <linux-kselftest@...r.kernel.org>,
        Fenghua Yu <fenghua.yu@...el.com>,
        "Shuah Khan" <shuah@...nel.org>, Babu Moger <babu.moger@....com>,
        "Sai Praneeth Prakhya" <sai.praneeth.prakhya@...el.com>,
        <linux-kernel@...r.kernel.org>
CC:     Shaopeng Tan <tan.shaopeng@...fujitsu.com>
Subject: Re: [PATCH v2 01/24] selftests/resctrl: Add resctrl.h into build deps

Hi Ilpo,

On 4/18/2023 4:44 AM, Ilpo Järvinen wrote:
> Makefile only lists *.c as build dependecies for the restctrl_tests

dependecies -> dependencies

restctrl_tests -> resctrl_tests

> executable which excludes resctrl.h.
> 
> Add *.h to wildcard() cover also resctrl.h.

I find this a bit hard to parse. How about
"Add *.h to wildcard() to include resctrl.h."

(considering the problem statement indicates that
resctrl.h was "excluded", having it now "included"
seems to match)

> 
> Fixes: 591a6e8588fc ("selftests/resctrl: Add basic resctrl file system operations and data")
> Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
> ---
>  tools/testing/selftests/resctrl/Makefile | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tools/testing/selftests/resctrl/Makefile b/tools/testing/selftests/resctrl/Makefile
> index 73d53257df42..2dc7da221795 100644
> --- a/tools/testing/selftests/resctrl/Makefile
> +++ b/tools/testing/selftests/resctrl/Makefile
> @@ -7,4 +7,4 @@ TEST_GEN_PROGS := resctrl_tests
>  
>  include ../lib.mk
>  
> -$(OUTPUT)/resctrl_tests: $(wildcard *.c)
> +$(OUTPUT)/resctrl_tests: $(wildcard *.c *.h)

How about a simpler *.[ch]? Seems like this pattern is
popular in selftest code.

Reinette