linux-kernel - Re: [PATCH] iio: light: al3320a: Handle ACPI device CALS0001

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20230423120744.568f107d@jic23-huawei>
Date:   Sun, 23 Apr 2023 12:07:44 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Marius Hoch <mail@...iushoch.de>
Cc:     Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, Hans de Goede <hdegoede@...hat.com>
Subject: Re: [PATCH] iio: light: al3320a: Handle ACPI device CALS0001

On Thu, 20 Apr 2023 20:23:14 +0200
Marius Hoch <mail@...iushoch.de> wrote:

> This sensor can be found as CALS0001 on the Lenovo Yoga
> Tablet 2 series.
> 
> Tested on a Lenovo Yoga Tablet 2 1051-F.
> 
> Signed-off-by: Marius Hoch <mail@...iushoch.de>

I made a small tweak.  This driver includes of.h to get
the ID table, which is less than ideal anyway.  Now you've added
a second table, I've switched that for mod_devicetable.h which is
the include that should have been used in the first place.

Applied with that and a not in the patch description to the togreg
branch of iio.git which is initially pushed out as testing for 0-day to
see if it can find anything we missed.

Thanks,

Jonathan

> ---
>  drivers/iio/light/al3320a.c | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/drivers/iio/light/al3320a.c b/drivers/iio/light/al3320a.c
> index 9ff28bbf34bb..ffcb65cbc125 100644
> --- a/drivers/iio/light/al3320a.c
> +++ b/drivers/iio/light/al3320a.c
> @@ -247,11 +247,18 @@ static const struct of_device_id al3320a_of_match[] = {
>  };
>  MODULE_DEVICE_TABLE(of, al3320a_of_match);
>  
> +static const struct acpi_device_id al3320a_acpi_match[] = {
> +	{"CALS0001"},
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(acpi, al3320a_acpi_match);
> +
>  static struct i2c_driver al3320a_driver = {
>  	.driver = {
>  		.name = AL3320A_DRV_NAME,
>  		.of_match_table = al3320a_of_match,
>  		.pm = pm_sleep_ptr(&al3320a_pm_ops),
> +		.acpi_match_table = al3320a_acpi_match,
>  	},
>  	.probe_new	= al3320a_probe,
>  	.id_table	= al3320a_id,
> 
> base-commit: cb0856346a60fe3eb837ba5e73588a41f81ac05f