linux-kernel - Re: [PATCH] drivers: w1: slaves: Drop unnecessary explicit casting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6be75dac-0904-390d-023b-a533f79073ce@kernel.org>
Date:   Sun, 23 Apr 2023 15:38:19 +0200
From:   Krzysztof Kozlowski <krzk@...nel.org>
To:     Anup Sharma <anupnewsmail@...il.com>, zbr@...emap.net
Cc:     linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: w1: slaves: Drop unnecessary explicit casting

On 20/04/2023 02:21, Anup Sharma wrote:
> Provide correct specifiers while printing error logs to discard the use
> of unnecessary explicit casting.
> 
> Signed-off-by: Anup Sharma <anupnewsmail@...il.com>
> ---
>  drivers/w1/slaves/w1_ds2433.c  | 6 +++---
>  drivers/w1/slaves/w1_ds28e04.c | 8 ++++----
>  2 files changed, 7 insertions(+), 7 deletions(-)
> 
> diff --git a/drivers/w1/slaves/w1_ds2433.c b/drivers/w1/slaves/w1_ds2433.c
> index 0f72df15a024..ba441d42b0b0 100644
> --- a/drivers/w1/slaves/w1_ds2433.c
> +++ b/drivers/w1/slaves/w1_ds2433.c
> @@ -213,15 +213,15 @@ static ssize_t eeprom_write(struct file *filp, struct kobject *kobj,
>  #ifdef CONFIG_W1_SLAVE_DS2433_CRC
>  	/* can only write full blocks in cached mode */
>  	if ((off & W1_PAGE_MASK) || (count & W1_PAGE_MASK)) {
> -		dev_err(&sl->dev, "invalid offset/count off=%d cnt=%zd\n",
> -			(int)off, count);
> +		dev_err(&sl->dev, "invalid offset/count off=%pe cnt=%zd\n",
> +			off, count);

I don't think you tested this patch. Why do you think off is a pointer?

Best regards,
Krzysztof