linux-kernel - Re: [net PATCH 9/9] octeontx2-pf: mcs: Do not reset PN while updating secy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20230423165616.GL4782@unreal>
Date:   Sun, 23 Apr 2023 19:56:16 +0300
From:   Leon Romanovsky <leon@...nel.org>
To:     Geetha sowjanya <gakula@...vell.com>
Cc:     netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        kuba@...nel.org, davem@...emloft.net, edumazet@...gle.com,
        pabeni@...hat.com, richardcochran@...il.com, sgoutham@...vell.com,
        sbhatta@...vell.com, hkelam@...vell.com
Subject: Re: [net PATCH 9/9] octeontx2-pf: mcs: Do not reset PN while
 updating secy

On Sun, Apr 23, 2023 at 03:24:54PM +0530, Geetha sowjanya wrote:
> From: Subbaraya Sundeep <sbhatta@...vell.com>
> 
> After creating SecYs, SCs and SAs a SecY can be modified
> to change attributes like validation mode, protect frames
> mode etc. During this SecY update, packet number is reset to
> initial user given value by mistake. Hence do not reset
> PN when updating SecY parameters.
> 
> Fixes: c54ffc73601c ("octeontx2-pf: mcs: Introduce MACSEC hardware offloading")
> Signed-off-by: Subbaraya Sundeep <sbhatta@...vell.com>
> Signed-off-by: Sunil Goutham <sgoutham@...vell.com>
> Signed-off-by: Geetha sowjanya <gakula@...vell.com>
> ---
>  .../ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 15 ++++++++++-----
>  1 file changed, 10 insertions(+), 5 deletions(-)
> 

Thanks,
Reviewed-by: Leon Romanovsky <leonro@...dia.com>