linux-kernel - Re: [PATCH v13 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock controller driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAFBinCBGWOB2XLb6su=R3W684rKdK3pOgPFsCGx+Oyo_pgdeBg@mail.gmail.com>
Date:   Sun, 23 Apr 2023 23:30:38 +0200
From:   Martin Blumenstingl <martin.blumenstingl@...glemail.com>
To:     Dmitry Rokosov <ddrokosov@...rdevices.ru>
Cc:     neil.armstrong@...aro.org, jbrunet@...libre.com,
        mturquette@...libre.com, sboyd@...nel.org, robh+dt@...nel.org,
        krzysztof.kozlowski+dt@...aro.org, khilman@...libre.com,
        jian.hu@...ogic.com, kernel@...rdevices.ru, rockosov@...il.com,
        linux-amlogic@...ts.infradead.org, linux-clk@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v13 6/6] clk: meson: a1: add Amlogic A1 Peripherals clock
 controller driver

On Wed, Apr 5, 2023 at 9:59 PM Dmitry Rokosov <ddrokosov@...rdevices.ru> wrote:
[...]
> +static const struct of_device_id a1_periphs_clkc_match_table[] = {
> +       { .compatible = "amlogic,a1-clkc", },
> +       {},
nit-pick: please remove the comma after the sentinel

> +MODULE_DEVICE_TABLE(of, a1_periphs_clkc_match_table);
> +
> +static struct platform_driver a1_periphs_clkc_driver = {
> +       .probe = meson_a1_periphs_probe,
> +       .driver = {
> +               .name = "a1-clkc",
> +               .of_match_table = of_match_ptr(a1_periphs_clkc_match_table),
I wonder if we should drop of_match_ptr() here as no other meson clock
driver uses it.
Also there's commits like 00cb754ac622 ("clk: imx8mq: drop
of_match_ptr from of_device_id table") which explicitly remove it from
other drivers.

Apart form these two this patch looks great to me.


Best regards,
Martin