linux-kernel - RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl configuration

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sun, 23 Apr 2023 10:36:11 +0530
From:   "Alim Akhtar" <alim.akhtar@...sung.com>
To:     "'Krzysztof Kozlowski'" <krzysztof.kozlowski@...aro.org>,
        "'Rob Herring'" <robh+dt@...nel.org>,
        "'Krzysztof Kozlowski'" <krzysztof.kozlowski+dt@...aro.org>,
        <devicetree@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-samsung-soc@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
 configuration



> -----Original Message-----
> From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Sent: Saturday, April 22, 2023 12:32 AM
> To: Rob Herring <robh+dt@...nel.org>; Krzysztof Kozlowski
> <krzysztof.kozlowski+dt@...aro.org>; Alim Akhtar
> <alim.akhtar@...sung.com>; devicetree@...r.kernel.org; linux-arm-
> kernel@...ts.infradead.org; linux-samsung-soc@...r.kernel.org; linux-
> kernel@...r.kernel.org
> Cc: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Subject: [PATCH] ARM: dts: s5pv210: remove empty camera pinctrl
> configuration
> 
> The camera's pinctrl configuration is simply empty and not effective.
> Remove it to fix dtbs_check warnings like:
> 
>   s5pv210-torbreck.dtb: camera@...00000: pinctrl-0: True is not of type
> 'array'
> 
> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> ---

Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com>

>  arch/arm/boot/dts/s5pv210.dtsi | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/s5pv210.dtsi
> b/arch/arm/boot/dts/s5pv210.dtsi index d9436bbf77c8..faa3682ab5dd
> 100644
> --- a/arch/arm/boot/dts/s5pv210.dtsi
> +++ b/arch/arm/boot/dts/s5pv210.dtsi
> @@ -549,8 +549,6 @@ i2c1: i2c@...00000 {
> 
>  		camera: camera@...00000 {
>  			compatible = "samsung,fimc";
> -			pinctrl-names = "default";
> -			pinctrl-0 = <>;
>  			clocks = <&clocks SCLK_CAM0>, <&clocks
> SCLK_CAM1>;
>  			clock-names = "sclk_cam0", "sclk_cam1";
>  			#address-cells = <1>;
> --
> 2.34.1