linux-kernel - Re: [PATCH] drm/amd/display: Fix a test CalculatePrefetchSchedule()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Mon, 24 Apr 2023 16:13:12 -0400
From:   Hamza Mahfooz <hamza.mahfooz@....com>
To:     Christophe JAILLET <christophe.jaillet@...adoo.fr>,
        Harry Wentland <harry.wentland@....com>,
        Leo Li <sunpeng.li@....com>,
        Rodrigo Siqueira <Rodrigo.Siqueira@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        "Pan, Xinhui" <Xinhui.Pan@....com>,
        David Airlie <airlied@...il.com>,
        Daniel Vetter <daniel@...ll.ch>,
        Pavle Kotarac <Pavle.Kotarac@....com>,
        Nevenko Stupar <Nevenko.Stupar@....com>,
        Aric Cyr <aric.cyr@....com>
Cc:     dri-devel@...ts.freedesktop.org, kernel-janitors@...r.kernel.org,
        linux-kernel@...r.kernel.org, amd-gfx@...ts.freedesktop.org
Subject: Re: [PATCH] drm/amd/display: Fix a test CalculatePrefetchSchedule()

On 4/17/23 17:35, Christophe JAILLET wrote:
> It is likely Height was expected here, instead of Width.
> 
> Test the correct variable.
> 
> Fixes: 17529ea2acfa ("drm/amd/display: Optimizations for DML math")
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>

Applied, thanks!

> ---
>   drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> index b7c2844d0cbe..f294f2f8c75b 100644
> --- a/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> +++ b/drivers/gpu/drm/amd/display/dc/dml/dcn21/display_mode_vba_21.c
> @@ -810,7 +810,7 @@ static bool CalculatePrefetchSchedule(
>   			*swath_width_chroma_ub = dml_ceil(SwathWidthY / 2 - 1, myPipe->BlockWidth256BytesC) + myPipe->BlockWidth256BytesC;
>   	} else {
>   		*swath_width_luma_ub = dml_ceil(SwathWidthY - 1, myPipe->BlockHeight256BytesY) + myPipe->BlockHeight256BytesY;
> -		if (myPipe->BlockWidth256BytesC > 0)
> +		if (myPipe->BlockHeight256BytesC > 0)
>   			*swath_width_chroma_ub = dml_ceil(SwathWidthY / 2 - 1, myPipe->BlockHeight256BytesC) + myPipe->BlockHeight256BytesC;
>   	}
>   
-- 
Hamza