linux-kernel - Re: [PATCH v11 01/14] HP BIOSCFG driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <80c448f8-f043-460a-908f-e87e6b8215dc@t-8ch.de>
Date:   Mon, 24 Apr 2023 22:52:20 +0200
From:   Thomas Weißschuh <thomas@...ch.de>
To:     Jorge Lopez <jorgealtxwork@...il.com>
Cc:     hdegoede@...hat.com, platform-driver-x86@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v11 01/14] HP BIOSCFG driver - Documentation

Hi Jorge,

On 2023-04-24 11:11:41-0500, Jorge Lopez wrote:
> On Sat, Apr 22, 2023 at 3:51 PM Thomas Weißschuh <thomas@...ch.de> wrote:
> >
> > On 2023-04-20 11:54:41-0500, Jorge Lopez wrote:
> > > Based on the latest platform-drivers-x86.git/for-next
> > > ---
> > >  .../testing/sysfs-class-firmware-attributes   | 98 ++++++++++++++++++-
> > >  1 file changed, 96 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/Documentation/ABI/testing/sysfs-class-firmware-attributes b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > index 4cdba3477176..73d7b8fbc0b2 100644
> > > --- a/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > +++ b/Documentation/ABI/testing/sysfs-class-firmware-attributes
> > > @@ -22,6 +22,12 @@ Description:
> > >                       - integer: a range of numerical values
> > >                       - string
> > >
> > > +             HP specific types
> > > +             -----------------
> > > +                     - ordered-list - a set of ordered list valid values
> > > +                     - sure-start - report audit logs read from BIOS
> >
> > In the treevie you sent the Sure_Start attribute does not have
> > a "current_value".
> > This indicated that it's not actually a firmware attribute but just some
> > standalone sysfs attribute.
> >
> > In this case it should not be documented here, but handled the same way
> > as the SPM stuff.
> 
> I will update the documentation as indicated.

This will also need changes to the code.
Only the audit log stuff is needed then.