linux-kernel - Re: [PATCH v2] crypto: engine - Fix struct crypto_engine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3f8ba0cc-5665-916d-b211-b2d5d6e952f4@infradead.org>
Date:   Sun, 23 Apr 2023 18:25:33 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     David Yang <mmyangfl@...il.com>, linux-crypto@...r.kernel.org
Cc:     Herbert Xu <herbert@...dor.apana.org.au>,
        "David S. Miller" <davem@...emloft.net>,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] crypto: engine - Fix struct crypto_engine_op doc

Hi,

On 4/23/23 17:29, David Yang wrote:
> Remove redundant underscore and fix some grammar in prepare_request doc.
> 
> Reported-by: Randy Dunlap <rdunlap@...radead.org>

No, I didn't report this issue. You either found it on your own or someone/something
else reported it.

> Link: https://lore.kernel.org/r/b58dc77c-c975-46cf-581c-368d9a87ae64@infradead.org

Also drop the Link: line.

> Signed-off-by: David Yang <mmyangfl@...il.com>
> ---
>  include/crypto/engine.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/crypto/engine.h b/include/crypto/engine.h
> index ae133e98d813..2038764b30c2 100644
> --- a/include/crypto/engine.h
> +++ b/include/crypto/engine.h
> @@ -78,7 +78,7 @@ struct crypto_engine {
>  
>  /*
>   * struct crypto_engine_op - crypto hardware engine operations
> - * @prepare__request: do some prepare if need before handle the current request
> + * @prepare_request: do some preparation if needed before handling the current request

That part looks good.

>   * @unprepare_request: undo any work done by prepare_request()
>   * @do_one_request: do encryption for current request
>   */

-- 
~Randy