linux-kernel - Re: [PATCH] drivers: nfc: nfcsim: remove return value check of `dev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <47e8113d-39ad-cf18-a763-89ee883da233@linaro.org>
Date:   Mon, 24 Apr 2023 09:01:38 +0200
From:   Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To:     Jianuo Kuang <u202110722@...t.edu.cn>,
        Thierry Escande <thierry.escande@...labora.com>,
        Samuel Ortiz <sameo@...ux.intel.com>
Cc:     hust-os-kernel-patches@...glegroups.com,
        Dongliang Mu <dzm91@...t.edu.cn>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drivers: nfc: nfcsim: remove return value check of
 `dev_dir`

On 24/04/2023 04:41, Jianuo Kuang wrote:
> Smatch complains that:
> nfcsim_debugfs_init_dev() warn: 'dev_dir' is an error pointer or valid
> 
> According to the documentation of the debugfs_create_dir() function,
> there is no need to check the return value of this function.
> Just delete the dead code.
> 
> Fixes: f9ac6273e5b8 ("NFC: nfcsim: Add support for sysfs control entry")
> Signed-off-by: Jianuo Kuang <u202110722@...t.edu.cn>
> Reviewed-by: Dongliang Mu <dzm91@...t.edu.cn>
> ---


Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>

Best regards,
Krzysztof